Ulysse/Helios-pr
Watch
1
0
Fork
You've already forked Helios-pr
 0
mirror of https://github.com/Ulysse2211/Helios-pr.git synced 2026-10-24 13:21:23 +02:00
Code Issues Projects Packages Wiki Activity

[PR #1] [MERGED] Fix lang selector #2

New issue
Closed
opened 2026-10-24 13:18:08 +02:00 by Ulysse · 0 comments
Ulysse commented 2026-10-24 13:18:08 +02:00
Owner

📋 Pull Request Information

Original PR: https://github.com/Ulysse2211/Helios-pr/pull/1
Author: @ErinMax
Created: 5/16/2024
Status: ✅ Merged
Merged: 5/16/2024
Merged by: @Ulysse2211

Base: change-language-in-settings ← Head: Fix-lang-selector

📝 Commits (2)

  • 225125f Merge pull request #1 from Ulysse2211/change-language-in-settings
  • a59a750 Fix the language selector on releases

📊 Changes

9 files changed (+1448 additions, -1402 deletions)

View changed files

📝 app/assets/js/configmanager.js (+29 -1)
📝 app/assets/js/langloader.js (+18 -1)
📝 electron-builder.yml (+1 -0)
📝 lang/_custom.toml (+25 -25)
📝 lang/en_US.toml (+0 -0)
📝 lang/es_ES.toml (+344 -344)
📝 lang/fr_FR.toml (+343 -343)
📝 lang/ja_JP.toml (+344 -344)
📝 lang/ko_KR.toml (+344 -344)

📄 Description

This aims to fix the releases because before it only worked in the dev environment, it works on Windows but still needs testing on MacOS and Ubuntu

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Ulysse2211/Helios-pr/pull/1 **Author:** [@ErinMax](https://github.com/ErinMax) **Created:** 5/16/2024 **Status:** ✅ Merged **Merged:** 5/16/2024 **Merged by:** [@Ulysse2211](https://github.com/Ulysse2211) **Base:** `change-language-in-settings` ← **Head:** `Fix-lang-selector` --- ### 📝 Commits (2) - [`225125f`](https://github.com/Ulysse2211/Helios-pr/commit/225125fc1273f2dbfa005f067a1a5461fccffac8) Merge pull request #1 from Ulysse2211/change-language-in-settings - [`a59a750`](https://github.com/Ulysse2211/Helios-pr/commit/a59a750f804fb7d71a97a6ddb0f869d5240e90d6) Fix the language selector on releases ### 📊 Changes **9 files changed** (+1448 additions, -1402 deletions) <details> <summary>View changed files</summary> 📝 `app/assets/js/configmanager.js` (+29 -1) 📝 `app/assets/js/langloader.js` (+18 -1) 📝 `electron-builder.yml` (+1 -0) 📝 `lang/_custom.toml` (+25 -25) 📝 `lang/en_US.toml` (+0 -0) 📝 `lang/es_ES.toml` (+344 -344) 📝 `lang/fr_FR.toml` (+343 -343) 📝 `lang/ja_JP.toml` (+344 -344) 📝 `lang/ko_KR.toml` (+344 -344) </details> ### 📄 Description This aims to fix the releases because before it only worked in the dev environment, it works on Windows but still needs testing on MacOS and Ubuntu --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Ulysse 2026-10-24 13:18:08 +02:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
mod-search
sync-language-in-game
nicer-login-page
fullscreen-options.txt
change-language-in-settings
non-zero-game-exit-code-overlay
css-px-to-rem
close-on-launch-option
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Ulysse/Helios-pr#2
No description provided.